gw-disable-submit-button-until-required-fields-are-filled-out.php: Fixed a compatibility issue with GP Populate Anything.
#910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fixed a compatibility issue with GP Populate Anything.
Comment on lines
+35
to
+36
| add_action( 'wp_footer', array( $this, 'output_script' ) ); | ||
| add_action( 'gform_preview_footer', array( $this, 'output_script' ) ); |
Contributor
There was a problem hiding this comment.
Was this to prevent AJAX errors?
Could we use gform_print_scripts instead?
Contributor
Author
There was a problem hiding this comment.
Yes, and I will check gform_print_scripts
Contributor
Author
There was a problem hiding this comment.
Doesnt work with gform_print_scripts, i think its because it not firing at the correct time.
Contributor
There was a problem hiding this comment.
Works for me considering this is a snippet. Thanks for checking!
claygriffiths
approved these changes
Oct 28, 2024
Comment on lines
+35
to
+36
| add_action( 'wp_footer', array( $this, 'output_script' ) ); | ||
| add_action( 'gform_preview_footer', array( $this, 'output_script' ) ); |
Contributor
There was a problem hiding this comment.
Works for me considering this is a snippet. Thanks for checking!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2740666744/72953
Summary
The Disable Submit Button Until Required Fields Are Filled Out snippet is conflicting with GPPA, causing the form to break. Populated fields just pulse and don't update.
Matt A's loom explaining the issue:
https://www.loom.com/share/e98e2369db5a43278f5d2706612fad54
After the update (fix):
https://www.loom.com/share/76f4bf19d9554486bde1a39e74e97ea4